Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix unstable schema test #8972

Merged
merged 4 commits into from
Apr 22, 2024
Merged

tests: Fix unstable schema test #8972

merged 4 commits into from
Apr 22, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Apr 20, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8968, close #8911

Problem Summary:
#8955 introduced a check on the cache gc_safepoint is not updated, but the background task of DDL sync make the ut unstable

What is changed and how it works?

  • Disable the background task when profiles.default.ddl_sync_interval_seconds == 0
  • Refine the code in TiDBSchemaManager.h with comments on locking schema_syncers_mutex
  • Refine the code in SchemaSyncTest to use temporary instance instead of the instance in global_context

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2024
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang JaySon-Huang self-assigned this Apr 20, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 21, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 22, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-21 04:17:38.123285802 +0000 UTC m=+743677.234332243: ☑️ agreed by Lloyd-Pottiger.
  • 2024-04-22 02:28:36.455938117 +0000 UTC m=+823535.566984566: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 4412105 into pingcap:master Apr 22, 2024
6 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_unstable_schema_test branch April 22, 2024 02:49
@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-8.1: #8974.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-7.5: #8975.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@ti-chi-bot
tests: Fix unstable schema test (#8972) (#8974)
e6ea28e 
close #8911, close #8968
ti-chi-bot bot pushed a commit that referenced this pull request May 7, 2024
@ti-chi-bot
tests: Fix unstable schema test (#8972) (#8975)
8940b70 
close #8911, close #8968
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @JaySon-Huang
tests: Fix unstable schema test (pingcap#8972) (pingcap#8975)
3f27b84 
close pingcap#8911, close pingcap#8968
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 20, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable ut SchemaSyncTest.PhysicalDropTableMeetsUnRemovedRegions Physically dropping table is slow sometime
4 participants
@JaySon-Huang @ti-chi-bot @JinheLin @Lloyd-Pottiger